pbacsko commented on code in PR #1000:
URL: https://github.com/apache/yunikorn-core/pull/1000#discussion_r1856701781
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -635,6 +636,9 @@ func (p *Preemptor) TryPreemption() (*AllocationResult,
bool) {
zap.String("victimNodeID", victim.GetNodeID()),
zap.String("victimQueue", victimQueue.Name),
)
+ // send event
+ message := fmt.Sprintf("Preempted by %v from
application %v in %v", p.ask.GetTag("kubernetes.io/meta/podName"),
p.ask.applicationID, p.application.queuePath)
Review Comment:
I looked at `preemption_test.go`, the simplest test case is
`TestTryPreemption`. You can add the extra code there to verify the event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
