craigcondit commented on code in PR #1001:
URL: https://github.com/apache/yunikorn-core/pull/1001#discussion_r1868486794
##########
pkg/scheduler/objects/reservation.go:
##########
@@ -21,37 +21,36 @@ package objects
import (
"go.uber.org/zap"
- "github.com/apache/yunikorn-core/pkg/common"
"github.com/apache/yunikorn-core/pkg/log"
)
type reservation struct {
- nodeID string
- appID string
- askKey string
- // these references must ONLY be used for ask, node and application
removal otherwise
+ appID string
+ nodeID string
+ allocKey string
+ // these references must ONLY be used for alloc, node and application
removal otherwise
// the reservations cannot be removed and scheduling might be impacted.
- app *Application
- node *Node
- ask *Allocation
+ app *Application
+ node *Node
+ alloc *Allocation
}
// The reservation inside the scheduler. A reservation object is never mutated
and does not use locking.
// The key depends on where the reservation was made (node or app).
// appBased must be true for a reservation for an app and false for a
reservation on a node
-func newReservation(node *Node, app *Application, ask *Allocation, appBased
bool) *reservation {
- if ask == nil || app == nil || node == nil {
+func newReservation(node *Node, app *Application, alloc *Allocation, appBased
bool) *reservation {
Review Comment:
I don't want to be pedantic either way though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
