ryankert01 commented on PR #1007: URL: https://github.com/apache/yunikorn-core/pull/1007#issuecomment-2560944762
Interest in helping create this test! jira link: https://issues.apache.org/jira/browse/YUNIKORN-3005 --- @wilfred-s I saw something interesting while trying to create the test: we don't have logic to decrease `qt.maxRunningApps` and `qt.maxResources` while [decreaseTrackedResource() on L159](https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/ugm/manager.go#L159) requires [it](https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/ugm/queue_tracker.go#L175) to be zero to be deleted. Therefore, in [decreaseTrackedResource() on L183](https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/ugm/manager.go#L183), it will not be deleted. Maybe we should relax/add some logic with `qt.maxRunningApps` and `qt.maxResources` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
