kaichiachen commented on code in PR #947:
URL: https://github.com/apache/yunikorn-k8shim/pull/947#discussion_r1929514777
##########
test/e2e/persistent_volume/persistent_volume_test.go:
##########
@@ -133,15 +134,16 @@ var _ = ginkgo.Describe("PersistentVolume", func() {
Ω(err).NotTo(HaveOccurred())
})
+ saName := "nfs-service-account"
+ crName := "nfs-cluster-role"
+ crbName := "nfs-cluster-role-binding" //nolint:gosec
+ serverName := "nfs-provisioner"
+ scName := "nfs-sc"
Review Comment:
Thanks @chenyulin0719 for helping me review! I put them to the begin of the
test file and keep align the naming style with other const
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
