kaichiachen commented on code in PR #950:
URL: https://github.com/apache/yunikorn-k8shim/pull/950#discussion_r1950421626
##########
pkg/cache/scheduler_callback.go:
##########
@@ -189,6 +190,10 @@ func (callback *AsyncRMCallback) PreemptionPredicates(args
*si.PreemptionPredica
if !ok {
index = -1
}
+ if index < math.MinInt32 || index > math.MaxInt32 {
+ // Handle the overflow scenario appropriately
+ panic(fmt.Sprintf("index value %d is out of int32 range",
index))
Review Comment:
I see, I used nolint to bypass warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
