pbacsko commented on code in PR #1012:
URL: https://github.com/apache/yunikorn-core/pull/1012#discussion_r1953958039
##########
pkg/metrics/queue.go:
##########
@@ -354,3 +355,8 @@ func (m *QueueMetrics)
SetQueuePendingResourceMetrics(resourceName string, value
func (m *QueueMetrics) SetQueuePreemptingResourceMetrics(resourceName string,
value float64) {
m.setQueueResource(QueuePreempting, resourceName, value)
}
+
+func (m *QueueMetrics) SetQueueMaxRunningAppsResourceMetrics(value uint64) {
+ resourceName := "apps"
+ m.setQueueResource(QueueMaxRunningApps, resourceName, float64(value))
+}
Review Comment:
1. `SetQueueMaxRunningAppsMetrics()` sounds more appropriate
2. Just inline "apps" directly when calling `setQueueResource()`
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1705,6 +1709,10 @@ func (sq *Queue) updatePreemptingResourceMetrics() {
}
}
+func (sq *Queue) updateMaxRunningAppsResourceMetrics() {
Review Comment:
nit: minus "Resource"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
