SophieTech88 commented on PR #962: URL: https://github.com/apache/yunikorn-k8shim/pull/962#issuecomment-2746019742
> Hi @SophieTech88 Thanks for the PR. I just noticed that there are 2 `ginkgo.AfterEach()` in `persistent_volume_test.go`. Maybe we could combine them? > > * https://github.com/SophieTech88/yunikorn-k8shim/blob/7dac085890a8a6648720d77a810b4917944984df/test/e2e/persistent_volume/persistent_volume_test.go#L163-L169 > * https://github.com/SophieTech88/yunikorn-k8shim/blob/7dac085890a8a6648720d77a810b4917944984df/test/e2e/persistent_volume/persistent_volume_test.go#L64-L68 Thanks for your suggestion. Just update the MR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
