mitdesai opened a new pull request, #1022: URL: https://github.com/apache/yunikorn-core/pull/1022
### What is this PR for? The binary search in the remove method used the LessThan() comparison function, which compares allocations based on priority and creation time. The comparison should be by allocation key. When multiple allocations have the same priority and creation time, it is possible that the binary search will find an allocation that is different than the one we want to remove. ### What type of PR is it? * [X] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [ ] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-3084 ### How should this be tested? Create a Job with 1000 executors. Delete all the executors. Atleast one of the executors will have issue getting removed. ### Screenshots (if appropriate) ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
