pbacsko commented on code in PR #1023:
URL: https://github.com/apache/yunikorn-core/pull/1023#discussion_r2145420417
##########
pkg/metrics/queue.go:
##########
@@ -53,13 +53,9 @@ const (
// QueueMetrics to declare queue metrics
type QueueMetrics struct {
- appMetricsLabel *prometheus.GaugeVec
- // Deprecated - To be removed in 1.7.0. Replaced with queue label
Metrics
- appMetricsSubsystem *prometheus.GaugeVec
+ appMetricsLabel *prometheus.GaugeVec
Review Comment:
Nit: now we only have a single metrics for apps, so rename this to
`appMetrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
