pbacsko commented on PR #1021: URL: https://github.com/apache/yunikorn-core/pull/1021#issuecomment-3418140904
Note: I merged master & pushed a refactoring commit. I did pretty much everything I recommended, plus: * Unexported some types * Renamed methods, variables * Removed unnecessary code * Tidied up function access a bit eg. `(l *LdapAccessImpl)` --> `(LdapAccessImpl)` * Fixed linter `staticcheck` complaints Regarding the config: that's one more step, so it still reads from a mounted file. But so far it's enough change for review, so let's do that as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
