wilfred-s commented on code in PR #1088:
URL: https://github.com/apache/yunikorn-core/pull/1088#discussion_r3316169266


##########
pkg/scheduler/objects/queue.go:
##########


Review Comment:
   We should optimise this as the passed in list of parent properties is a 
clean copy there is no reason to create a new copy. the filtering we can then 
do directly on the map entries inside the merge code.
   File a jira for that, please



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to