pbacsko commented on code in PR #1032:
URL: https://github.com/apache/yunikorn-k8shim/pull/1032#discussion_r3323118711
##########
pkg/shim/scheduler.go:
##########
@@ -69,13 +69,17 @@ func NewShimScheduler(scheduler api.SchedulerAPI, configs
*conf.SchedulerConf, b
// we have disabled re-sync to keep ourselves up-to-date
informerFactory :=
informers.NewSharedInformerFactory(kubeClient.GetClientSet(), 0)
- apiFactory := client.NewAPIFactory(scheduler, informerFactory, configs,
false)
+ apiFactory, err := client.NewAPIFactory(scheduler, informerFactory,
configs, false)
+ if err != nil {
+ log.Log(log.Shim).Fatal("problem in creating the api factory")
Review Comment:
log the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
