ayubpathan commented on PR #1086: URL: https://github.com/apache/yunikorn-core/pull/1086#issuecomment-4585991026
> @ayubpathan this seems to be a different solution for the same issue as is fixed in #1088. The merge code for the properties should handle the reset also. Can you please check that? If soo we can handle the cleanup of the mergeProperties here (see this [comment](https://github.com/apache/yunikorn-core/pull/1088#discussion_r3316169266) to make that reset nice and clean. Thanks @wilfred-s, I reviewed #1088. It covers the inherited-property reload path, which overlaps with the `ApplyConf` merge I added here. I agree that part should not be duplicated. The remaining issue in this PR is the reset of runtime fields derived from queue properties when a property is removed. I will rework this patch to keep the reset behavior and align it with the `mergeProperties/MergeParentProperties` path from #1088, then update the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
