wilfred-s commented on code in PR #1090: URL: https://github.com/apache/yunikorn-core/pull/1090#discussion_r3354980027
########## pkg/webservice/gzip.go: ########## @@ -0,0 +1,169 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +*/ + +package webservice + +import ( + "bytes" + "compress/gzip" + "net/http" + "strings" + + "go.uber.org/zap" + + "github.com/apache/yunikorn-core/pkg/log" +) + +// minCompressionSize is the minimum response body size in bytes required before gzip +// compression is applied. Responses smaller than this threshold are sent uncompressed +// because the gzip framing overhead would exceed any size savings. The value matches +// the typical Ethernet MTU (1500 bytes). Exposed as a var so tests can override it. +var minCompressionSize = 1500 Review Comment: Should we not account for some overhead in bytes and use 1400 so we can also fit the headers in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
