wilfred-s commented on code in PR #1095:
URL: https://github.com/apache/yunikorn-core/pull/1095#discussion_r3426027913
##########
pkg/scheduler/scheduler.go:
##########
@@ -120,7 +123,12 @@ func (s *Scheduler) internalQuotaPreemption() {
// Implement methods for Scheduler events
func (s *Scheduler) HandleEvent(ev interface{}) {
Review Comment:
fix this comment also,
can we add why the split is made here why?
##########
pkg/scheduler/scheduler.go:
##########
@@ -32,32 +32,35 @@ import (
"github.com/apache/yunikorn-scheduler-interface/lib/go/si"
)
-// Main Scheduler service that starts the needed sub services
+// The Scheduler service that starts the needed sub services
type Scheduler struct {
- clusterContext *ClusterContext // main context
- pendingEvents chan interface{} // queue for events
- activityPending chan bool // activity pending channel
- stop chan struct{} // channel to signal stop request
- healthChecker *HealthChecker
- nodesMonitor *nodesResourceUsageMonitor
+ clusterContext *ClusterContext // main context
+ pendingAllocEvents chan interface{} // queue for allocation and
application events
+ pendingInfraEvents chan interface{} // queue for node, config, and
registration events
+ activityPending chan bool // activity pending channel
+ stop chan struct{} // channel to signal stop request
+ healthChecker *HealthChecker
+ nodesMonitor *nodesResourceUsageMonitor
}
func NewScheduler() *Scheduler {
m := &Scheduler{}
m.clusterContext = newClusterContext()
- m.pendingEvents = make(chan interface{}, 1024*1024)
+ m.pendingAllocEvents = make(chan interface{}, 1024*1024)
+ m.pendingInfraEvents = make(chan interface{}, 1024*1024)
Review Comment:
Do we need 1 Million events to be buffered in each channel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
