adityadtu5 commented on code in PR #227:
URL: https://github.com/apache/yunikorn-release/pull/227#discussion_r3433379588
##########
Makefile:
##########
@@ -118,95 +130,69 @@ $(SHELLCHECK_BIN):
@curl -sSfL
"https://github.com/koalaman/shellcheck/releases/download/$(SHELLCHECK_VERSION)/$(SHELLCHECK_ARCHIVE)"
\
| tar -x -J --strip-components=1 -C "$(SHELLCHECK_PATH)"
"shellcheck-$(SHELLCHECK_VERSION)/shellcheck"
+# Install helm
+$(HELM_BIN):
+ @echo "installing helm $(HELM_VERSION)"
+ @mkdir -p "$(HELM_PATH)"
+ @curl -sSfL "https://get.helm.sh/$(HELM_ARCHIVE)" \
+ | tar -x -z --strip-components=1 -C "$(HELM_PATH)"
"$(HELM_ARCHIVE_BASE)/helm"
+
# Install golangci-lint
$(GOLANGCI_LINT_BIN):
@echo "installing golangci-lint v$(GOLANGCI_LINT_VERSION)"
@mkdir -p "$(GOLANGCI_LINT_PATH)"
@curl -sSfL
"https://github.com/golangci/golangci-lint/releases/download/v$(GOLANGCI_LINT_VERSION)/$(GOLANGCI_LINT_ARCHIVE)"
\
| tar -x -z --strip-components=1 -C "$(GOLANGCI_LINT_PATH)"
"$(GOLANGCI_LINT_ARCHIVEBASE)/golangci-lint"
-.PHONY: format
-# Run go fmt and goimports
-format:
Review Comment:
why we removed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
