wilfred-s commented on code in PR #1103:
URL: https://github.com/apache/yunikorn-core/pull/1103#discussion_r3564180066
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -133,10 +133,11 @@ func (p *Preemptor) initQueueSnapshots() {
}
// initWorkingState builds helper data structures required to compute a
solution
-func (p *Preemptor) initWorkingState() {
+// returns the number of reservations released while preparing the data
structures
+func (p *Preemptor) initWorkingState() int {
Review Comment:
You are not missing anything. Not yet you are correct, I have logged a
separate jira for that as that change is
bigger.[YUNIKORN-3319](https://issues.apache.org/jira/browse/YUNIKORN-3319)
The released reservations are not accounted for correctly. The partition
tracks the number of reservations but this preemption code does not pass back
the released reservations and does not update that counter. That should be
fixed to make sure we do not run the reservation schedulling loop unneeded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
