PoiBlackTea commented on code in PR #231:
URL: https://github.com/apache/yunikorn-release/pull/231#discussion_r3600393131
##########
helm-charts/yunikorn/values.yaml:
##########
@@ -88,6 +88,29 @@ ingress:
pathType: Prefix
tls: []
+# HTTPRoute configuration to expose the YuniKorn UI through the Gateway API.
+# This requires the Gateway API CRDs to be installed on your cluster.
+#
+# When enabled is true, the HTTPRoute resource will be deployed.
+# Note: You must configure `parentRefs` to attach the route to an existing
Gateway.
+httpRoute:
+ enabled: false
+ annotations: {}
+
+ # At least one parentRef is required to attach the route to a Gateway.
+ parentRefs: []
+ # - group: gateway.networking.k8s.io
+ # kind: Gateway
+ # name: yunikorn-gateway
+ # namespace: yunikorn
+
+ # Hostnames to match for the HTTPRoute.
+ hostnames: []
+ # - chart-example.local
+
+ # Custom routing rules. If empty, a default rule mapping to the UI service
is used.
+ # rules: []
Review Comment:
While it's true that the ultimate destination is always the YuniKorn
webservice, the Gateway API's rules offer powerful traffic management features
that users might need to configure.
By allowing rules to be overridden, users can leverage advanced Gateway API
features, such as:
- URLRewrite / Path redirects (e.g., rewriting /yunikorn to /)
If rules is left empty (which is the default), we automatically generate a
default rule that maps all traffic directly to the webservice. This keeps it
simple out of the box while preserving the full flexibility of the Gateway API
for advanced ingress requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
