wilfred-s commented on code in PR #1104:
URL: https://github.com/apache/yunikorn-core/pull/1104#discussion_r3627003757
##########
pkg/scheduler/partition.go:
##########
@@ -1504,6 +1504,45 @@ func (pc *PartitionContext) removeAllocation(release
*si.AllocationRelease) ([]*
return nil, nil
}
+ // Handle shim-initiated scheduling failure: roll the allocation back
to a pending ask
Review Comment:
We should do the same for the code in if if clause for
`TerminationType_PLACEHOLDER_REPLACED` in the same function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]