thc1006 commented on PR #1053: URL: https://github.com/apache/yunikorn-k8shim/pull/1053#issuecomment-5077307365
Hi @wilfred-s, I've reworked this along the lines you suggested. The aggregation now happens inside the single pass over the task groups: `GetTaskGroupsFromAnnotation` calls `validateTaskGroupResources` once per group, and that checks the sign and the overflow inline, updates the running totals directly, and returns an error on failure. The separate second range is gone. I also rebased onto current master. Could you take another look when you have a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
