wilfred-s opened a new pull request, #1111:
URL: https://github.com/apache/yunikorn-core/pull/1111

   ### Description
   Calling StartService for an existing stopped EventPublisher does not create 
a new stop channel. Event publisher will ignore start request when already 
running. Calling stop twice on the EventPublisher panics as it tries to close 
an already closed channel.
   
   Move config callback setup for event system into the Init() allowing a start 
from config even when system start did not start the event system. Move stop 
channel creation into start and stop functions
   
   Cleanup layout in event system and publisher
   Remove exports from functions and objects where possible.
   
   ### Type of change
   - [X] Bug Fix
   
   ### Jira issue
   Jira ID : https://issues.apache.org/jira/browse/YUNIKORN-3336
   
   - [X] I have created a Jira issue for this pull request.
   - [X] The Jira ID is part of the title of this pull request.
   
   ### AI Tooling
   If an AI tool was used:
   - [ ] The PR includes the phrase "Generated by \<tool>", where \<tool> is 
the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy.
   
   Check https://www.apache.org/legal/generative-tooling.html for details.
   
   ### How has this been tested?
   - [X] New unit tests were added to cover new or changed code paths.
   - [X] `make test_all` was run, and no failures reported.
   - [ ] A pull request will be opened for new e2e tests 
(apache/yunikorn-k8shim repository).
   
   ### Questions:
   - [ ] The change needs documentation, a pull request for 
apache/yunikorn-site repository will be created.
   - [ ] There is breaking changes for older versions: jira is tagged with 
`release-notes` label.
   - [ ] The licenses files needs to be updated.
   
   ### Screenshots or other details
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to