manirajv06 commented on code in PR #566:
URL: https://github.com/apache/yunikorn-site/pull/566#discussion_r3663200256


##########
docs/api/scheduler.md:
##########
@@ -34,6 +34,8 @@ are returned in units of bytes while resources of type 
`vcore` are returned in u
 
 Under the `allocations` field in the response content for the app/node-related 
calls in the following spec, `placeholderUsed` refers to whether or not the 
allocation is a replacement for a placeholder. If true, `requestTime` is the 
creation time of its placeholder allocation, otherwise it's that of the 
allocation's ask. `allocationTime` is the creation time of the allocation, and 
`allocationDelay` is simply the difference between `allocationTime` and 
`requestTime`.
 
+Queue responses include runtime fields for quota preemption and 
unschedulable-ask backoff. `quotaPreemptionStartTime` is the quota preemption 
start time in Unix nanoseconds and is omitted when not set. 
`isQuotaPreemptionRunning` indicates whether quota preemption run is in 
progress for the queue. `unschedAskBackoff` is the configured unschedulable-ask 
backoff threshold and is omitted when zero. `askBackoffDelay` is the effective 
backoff delay as a Golang duration string.
+

Review Comment:
   I don't think we need this para at all. Don't see any need to highlight any 
specific point as these are just normal variables like others.



##########
docs/api/scheduler.md:
##########
@@ -288,7 +290,10 @@ For the default queue hierarchy (only `root.default` leaf 
queue exists) a simila
                 "isPreemptionFence": true,
                 "preemptionDelay": "30s",
                 "isPriorityFence": true,
-                "priorityOffset": 3
+                "priorityOffset": 3,
+                "isQuotaPreemptionRunning": false,

Review Comment:
   quotaPreemptionStartTime ?



##########
docs/api/scheduler.md:
##########
@@ -373,7 +378,9 @@ If the query parameter `subtree` is not set, the queue's 
children will not be re
     "isPreemptionFence": true,
     "preemptionDelay": "30s",
     "isPriorityFence": true,
-    "priorityOffset": 3
+    "priorityOffset": 3,
+    "isQuotaPreemptionRunning": false,

Review Comment:
   quotaPreemptionStartTime ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to