kaijaytu commented on PR #570: URL: https://github.com/apache/yunikorn-site/pull/570#issuecomment-5162912964
While working on this PR, I noticed that the design doc (quota_preemptor.md) has several descriptions that no longer match the actual implementation: Timer behavior (line 109): The design doc says "timers reset and start again from the beginning" on any config change. The actual code uses delta adjustment (startTime += newDelay - oldDelay) for delay changes, and preserves the earliest startTime for consecutive quota decreases. Delay format and placement: The design doc shows the delay as an integer in seconds under the resources: block (e.g. quota.preemption.delay: 7200). The implementation uses Go time.Duration format as a queue properties: entry. Restart section (lines 113115): Only vaguely says the timer "would start again from the beginning." Doesn't explain that IncAllocatedResource() during recovery triggers setPreemptionTime() when usage > max. These are out of scope for this PR since YUNIKORN-3248 targets the user guide only. Should I file a separate JIRA to update the design doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
