kaijaytu commented on PR #1116: URL: https://github.com/apache/yunikorn-core/pull/1116#issuecomment-5163631728
Thanks for the review! Addressed both points: 1. **Logging retained**: Added per-reservation INFO log inside `unreserveForApp()`, so both call sites (tryRequiredNode and preemption initWorkingState) now automatically get per-reservation logging with triggering/reserving app IDs, allocation key, and node ID. > looks good. > > can we improve the logging? or can we retain the logging more or less in a similar way? 2. **Rebased** onto latest `upstream/master` (includes #1108). > Test failures are not related. [PR](https://github.com/apache/yunikorn-core/pull/1108) has gone in. Can you rebase the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
