tigerquoll commented on code in PR #1122:
URL: https://github.com/apache/yunikorn-core/pull/1122#discussion_r3757553623
##########
pkg/scheduler/objects/application.go:
##########
@@ -2278,6 +2330,10 @@ func (sa *Application) GetAskMaxPriority() int32 {
func (sa *Application) cleanupAsks() {
sa.requests = make(map[string]*Allocation)
sa.sortedRequests = nil
+ // a Failed app can still hold pending asks: reset the histogram or the
consistency check would
+ // fire on terminal apps.
Review Comment:
Comment corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
