manirajv06 commented on code in PR #1125:
URL: https://github.com/apache/yunikorn-core/pull/1125#discussion_r3773527102
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -88,37 +88,39 @@ func NewPreemptor(application *Application, headRoom
*resources.Resource, preemp
}
// CheckPreconditions performs simple sanity checks designed to determine if
preemption should be attempted
-// for an ask. If checks succeed, updates the ask preemption check time.
-func (p *Preemptor) CheckPreconditions() bool {
+// for an ask. If checks succeed, updates the ask preemption check time. The
checks only depend on the ask
+// and the preemption delay, so they run before a Preemptor is built to keep
that allocation off the path
+// taken by asks that cannot preempt anyway.
Review Comment:
Updated comment is verbose and don't think it is required. Older comment is
good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
