PoiBlackTea commented on code in PR #1065:
URL: https://github.com/apache/yunikorn-k8shim/pull/1065#discussion_r3791072554
##########
pkg/plugin/predicates/predicate_manager.go:
##########
@@ -46,8 +46,8 @@ import (
type PredicateManager interface {
EventsToRegister(queueingHintFn fwk.QueueingHintFn)
[]fwk.ClusterEventWithHint
- Predicates(pod *v1.Pod, node *framework.NodeInfo, allocate bool)
(plugin string, error error)
- PreemptionPredicates(pod *v1.Pod, node *framework.NodeInfo, victims
[]*v1.Pod, startIndex int) (index int)
+ Predicates(pod *v1.Pod, node *framework.NodeInfo, allocate bool)
(string, error)
+ PreemptionPredicates(pod *v1.Pod, node *framework.NodeInfo, victims
[]*v1.Pod, startIndex int) int
Review Comment:
NP. This is the only interface in this change where the named returns
carried meaningful semantics beyond what the types convey. The other removals
are either mocks, exported functions with self-descriptive return types, or
anonymous functions in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
