manirajv06 commented on code in PR #1129:
URL: https://github.com/apache/yunikorn-core/pull/1129#discussion_r3794524323
##########
pkg/scheduler/partition.go:
##########
@@ -1350,7 +1350,7 @@ func (pc *PartitionContext) UpdateAllocation(alloc
*objects.Allocation) (request
return false, false, nil
}
-func (pc *PartitionContext) handleForeignAllocation(allocationKey,
applicationID, nodeID string, node *objects.Node, alloc *objects.Allocation)
(requestCreated bool, allocCreated bool, err error) {
Review Comment:
Returned values from this method are returned as is even from the caller
UpdateAllocation(), so not sure about the loss you are explaining here and also
need for comment about the same. Does not look like values are inherited from
UpdateAllocation.
or Am I missing anything?
If you are good, I can take the PR forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
