wilfred-s commented on code in PR #1074:
URL: https://github.com/apache/yunikorn-k8shim/pull/1074#discussion_r3843042572
##########
pkg/shim/scheduler.go:
##########
@@ -225,13 +227,16 @@ func (ss *KubernetesShim) Run() error {
func (ss *KubernetesShim) Stop() {
log.Log(log.ShimScheduler).Info("stopping scheduler")
Review Comment:
NIT: move this inside the `stopOnce`. Logging now shows
```
stopping scheduler
scheduler is already stopped
```
Would be nice to only log the stopping line if we really do the work,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
