manirajv06 commented on PR #167: URL: https://github.com/apache/yunikorn-scheduler-interface/pull/167#issuecomment-5407541211
Just realised that DRA Bindings doesn't require any extra communication between core & shim for Binding process. In other words, Core doesn't need to make any additional call to shim via SI like PreFilter & Filter predicate checks. Call to Reserve, PreBind & Unreserve of PredicateManager could happen from task#postTaskAllocated() through context.go. It is already being followed in [Shim PR](https://github.com/apache/yunikorn-k8shim/pull/1073). We don't really need any SI changes and its implementation in Shim scheduler_callback.go. Hence this PR would be closed and scheduler_callback.go changes in [Shim PR](https://github.com/apache/yunikorn-k8shim/pull/1073) would be reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
