tigerquoll commented on PR #1043:
URL: https://github.com/apache/yunikorn-k8shim/pull/1043#issuecomment-5565656170
Heads-up that this PR is currently blocking everything else: **master does
not compile without it.**
The YUNIKORN-3435 dependency bump (`a2222d65`) pulled in a
scheduler-interface that adds `PreFilterPredicates` to
`api.ResourceManagerCallback`, but the shim-side implementation lands here, so
a clean checkout of master fails to build:
```
pkg/cache/scheduler_callback.go:44:37: cannot use &AsyncRMCallback{} (value
of type *AsyncRMCallback) as
api.ResourceManagerCallback value in variable declaration: *AsyncRMCallback
does not implement
api.ResourceManagerCallback (missing method PreFilterPredicates)
```
`pkg/cache`, `pkg/cmd/shim` and `pkg/shim` all fail with `[build failed]`.
Master's own CI has been red on this since 4 Sep — most recent run
[33974617433](https://github.com/apache/yunikorn-k8shim/actions/runs/33974617433)
— and every open PR inherits the failure on rebase, so unit-test results
across the repo are currently uninformative.
Not asking to shortcut the review here; just flagging that the SI/core side
went in ahead of the shim side, so this one is on the critical path.
Generated by the Author with assistance from Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
