pan3793 commented on code in PR #4665: URL: https://github.com/apache/zeppelin/pull/4665#discussion_r1354998647
########## .github/workflows/core.yml: ########## @@ -411,6 +411,11 @@ jobs: run: | rm -rf spark/interpreter/metastore_db ./mvnw verify -pl spark-submit,spark/interpreter -am -Dtest=org/apache/zeppelin/spark/* -Pspark-3.4 -Pspark-scala-2.13 -Phadoop3 -Pintegration -DfailIfNoTests=false ${MAVEN_ARGS} + - name: run spark-3.5 tests with scala-2.13 and python-${{ matrix.python }} + if: matrix.python >= '3.8' + run: | + rm -rf spark/interpreter/metastore_db + ./mvnw verify -pl spark-submit,spark/interpreter -am -Dtest=org/apache/zeppelin/spark/* -Pspark-3.5 -Pspark-scala-2.13 -Phadoop3 -Pintegration -DfailIfNoTests=false ${MAVEN_ARGS} Review Comment: Remove Hadoop2 support would be a big change, I'm not very familiar with Flink, but for Spark, it requires at least Spark 3.x to support Hadoop 3, the Livy module still uses Spark 2.4.8. And Spark moved to use Hadoop Shaded client since 3.2.0, which is a quite big change for Hadoop deps management. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org