pan3793 commented on code in PR #4688: URL: https://github.com/apache/zeppelin/pull/4688#discussion_r1385393614
########## flink/flink-scala-parent/pom.xml: ########## @@ -874,86 +860,12 @@ </build> <profiles> - - <profile> - <id>flink-113</id> - <properties> - <flink.version>${flink1.13.version}</flink.version> - </properties> - <dependencies> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-runtime_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-table-runtime-blink_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-table-planner-blink_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - <exclusions> - <exclusion> - <groupId>org.reflections</groupId> - <artifactId>reflections</artifactId> - </exclusion> - </exclusions> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-python_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - </dependencies> - </profile> - - <profile> - <id>flink-114</id> - <properties> - <flink.version>${flink1.14.version}</flink.version> - </properties> - <dependencies> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-runtime</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-table-planner_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>org.apache.flink</groupId> - <artifactId>flink-python_${flink.scala.binary.version}</artifactId> - <version>${flink.version}</version> - <scope>provided</scope> - </dependency> - </dependencies> - </profile> - <profile> <id>flink-115</id> Review Comment: the profile `hive-1` below is retained because that Flink 1.15 still supports Hive 1.x, but since Flink 1.16, only Hive 2.3 or 3.1 is supported. Actually, Flink 1.15 is EOL(I assume that because the community is discussing the final version of 1.16) too - https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/connectors/table/hive/overview/ - https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/connectors/table/hive/overview/ - https://www.mail-archive.com/dev@flink.apache.org/msg71005.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org