jongyoul commented on code in PR #4706:
URL: https://github.com/apache/zeppelin/pull/4706#discussion_r1494587876
##########
mongodb/src/main/java/org/apache/zeppelin/mongodb/MongoDbInterpreter.java:
##########
@@ -117,6 +125,67 @@ public InterpreterResult interpret(String script,
InterpreterContext context) {
executor.setWatchdog(new ExecuteWatchdog(commandTimeout));
final CommandLine cmdLine =
CommandLine.parse(getProperty("mongo.shell.path"));
+ /* added support for API versions */
+ String apiVersion = getProperty("mongo.server.api.version", "");
+ if (!"".equalsIgnoreCase(apiVersion)){
+ cmdLine.addArgument("--apiVersion", false);
+ cmdLine.addArgument(apiVersion, false);
+ }
+
+ /* adding support for SSL for and TLS for documentDB */
+ String runWithSSL = getProperty("mongo.server.ssl.enabled", "false");
+ if ("true".equalsIgnoreCase(runWithSSL))
Review Comment:
nit: `Boolean.valueOf(...)` or `Boolean.parseBoolean(...)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
