pan3793 commented on code in PR #4719:
URL: https://github.com/apache/zeppelin/pull/4719#discussion_r1495657266


##########
pom.xml:
##########
@@ -240,12 +239,6 @@
         <version>${slf4j.version}</version>
       </dependency>
 
-      <dependency>
-        <groupId>log4j</groupId>
-        <artifactId>log4j</artifactId>

Review Comment:
   removing the definition from `dependencyManagement` does not mean excluding 
the jar from the final binary tarball, there is still a chance that log4j is 
collected as the transitive dependency into the final tarball, additional 
manual checks are required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to