Reamer commented on code in PR #4731:
URL: https://github.com/apache/zeppelin/pull/4731#discussion_r1522948779
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/conf/ZeppelinConfigurationTest.java:
##########
@@ -41,7 +41,7 @@ public void cleanup() {
}
@Test
- public void getAllowedOrigins2Test() throws MalformedURLException {
Review Comment:
In general, I agree with you. Unnecessary diffs should be avoided. I myself
use SonarLint https://www.sonarsource.com/products/sonarlint/ in my IDE to
write clean code. Due to SonarLint and the IDE, many things are now marked that
should be done differently with newer Java versions or JUnit versions. To
prevent the markings from becoming too many and the important markings from
being overlooked, I carry out such clean-up work automatically during
development.
Unfortunately, this clean-up work distracts from the actual changes, which
is why I'm using a separate PR this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
