Reamer commented on code in PR #4726:
URL: https://github.com/apache/zeppelin/pull/4726#discussion_r1531863628
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -117,37 +118,25 @@ private void loadXMLConfig(@Nullable String filename)
throws ConfigurationExcept
}
}
- public static ZeppelinConfiguration create() {
- if (conf != null) {
- return conf;
- }
- return ZeppelinConfiguration.create(null);
+ public static ZeppelinConfiguration load() {
Review Comment:
With this name change, it was easier to see the usage. Also, I think
`create` as a method name is not really well chosen, it loads the configuration
from a file. I already have a `reload` method in mind, but that is far in the
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
