kevinjmh commented on code in PR #4582:
URL: https://github.com/apache/zeppelin/pull/4582#discussion_r1579043869
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/scheduler/RemoteScheduler.java:
##########
@@ -34,14 +36,14 @@
public class RemoteScheduler extends AbstractScheduler {
private static final Logger LOGGER =
LoggerFactory.getLogger(RemoteScheduler.class);
- private RemoteInterpreter remoteInterpreter;
- private ExecutorService executor;
+ private final RemoteInterpreter remoteInterpreter;
+ private final ExecutorService executor;
public RemoteScheduler(String name,
- ExecutorService executor,
RemoteInterpreter remoteInterpreter) {
super(name);
- this.executor = executor;
+ this.executor =
+ Executors.newSingleThreadExecutor(new SchedulerThreadFactory("FIFO-" +
name + "-"));
Review Comment:
I try to replace this line with `Executors.newFixedThreadPool(10, new
SchedulerThreadFactory(name));` and concurrent querys run normally. So there is
two level scheduler: `RemoteScheduler` in zengine and another one in
`JDBCInterpreter`.
https://github.com/apache/zeppelin/blob/debfa7fcc23d6f5ea2f0664308cdbe7eba78b419/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreter.java#L339-L355
https://github.com/apache/zeppelin/blob/47a86ac5fcd71f299e8bf605f25a070c478a2905/jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java#L1075-L1081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
