Reamer commented on code in PR #4765:
URL: https://github.com/apache/zeppelin/pull/4765#discussion_r1624830148
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/user/Credentials.java:
##########
@@ -139,7 +139,7 @@ private void loadCredentials() throws IOException {
private void loadFromFile() throws IOException {
try {
String json = storage.loadCredentials();
- if (json != null && encryptor != null) {
+ if (json != null && encryptor != null && !json.isEmpty()) {
Review Comment:
```suggestion
if (encryptor != null && StringUtils.isNotBlank(json)) {
```
The result is almost the same, the code is just a bit more elegant. A blank
string does not need to be encrypted either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
