seung-00 commented on code in PR #4789:
URL: https://github.com/apache/zeppelin/pull/4789#discussion_r1713984179
##########
zeppelin-web/src/components/websocket/websocket-event.factory.js:
##########
@@ -172,7 +172,7 @@ function WebsocketEventFactory($rootScope, $websocket,
$location, baseUrlSrv, sa
closeByBackdrop: false,
closeByKeyboard: false,
title: 'Details',
- message: _.escape(data.info.toString()),
+ message: _.escape(data.info.toString()).replace(/\n/g, '<br>'),
Review Comment:
I added newline processing to the error popup message. It could help users
better understand the message.
##########
zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepoTest.java:
##########
@@ -45,22 +45,21 @@ class VFSNotebookRepoTest {
private ZeppelinConfiguration zConf;
private NoteParser noteParser;
private VFSNotebookRepo notebookRepo;
- private File notebookDir;
Review Comment:
I removed this field. I thought the `notebookRepo.rootNotebookFolder` would
be enough to check notebook directory.
It is also related to the issue that a directory is created every time the
test is run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
