seung-00 commented on code in PR #4789:
URL: https://github.com/apache/zeppelin/pull/4789#discussion_r1715131271
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/VFSNotebookRepo.java:
##########
@@ -134,10 +137,23 @@ public Note get(String noteId, String notePath,
AuthenticationInfo subject)
NameScope.DESCENDENT);
String json = IOUtils.toString(noteFile.getContent().getInputStream(),
conf.getString(ConfVars.ZEPPELIN_ENCODING));
- Note note = noteParser.fromJson(noteId, json);
- // setPath here just for testing, because actually NoteManager will setPath
- note.setPath(notePath);
- return note;
+
+ try {
+ Note note = noteParser.fromJson(noteId, json);
+ // setPath here just for testing, because actually NoteManager will
setPath
+ note.setPath(notePath);
+ return note;
+ } catch (CorruptedNoteException e) {
+ String errorMessage = String.format(
Review Comment:
@Reamer
I've removed the newlines. I didn't consider the logging. To me, the popup
seems a bit harder to read now. But ensuring operational convenience could be
more important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
