tbonelee commented on code in PR #4788:
URL: https://github.com/apache/zeppelin/pull/4788#discussion_r1730398396


##########
zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js:
##########


Review Comment:
   Changing `completionSupportWithoutBackend` and 
`completionSupportWithBackend` to an arrow function might cause `this` to 
behave differently than expected.
   
   It looks like `this` inside the function is intended to refer to the object 
it's called on, but with an arrow function, it will instead refer to the `this` 
of `ParagraphCtrl`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to