Reamer commented on code in PR #4802:
URL: https://github.com/apache/zeppelin/pull/4802#discussion_r1730832772
##########
zeppelin-web/src/components/navbar/navbar.html:
##########
@@ -106,7 +106,7 @@
<li ng-if="ticket.principal && ticket.principal !== 'anonymous'"
role="separator" style="margin: 5px 0;" class="divider"></li>
<li ng-if="ticket.principal && ticket.principal !==
'anonymous'"><a ng-click="navbar.logout()">Logout</a></li>
<li role="separator" style="margin: 5px 0;" class="divider"></li>
- <li><a href="/next">Try the new Zeppelin</a></li>
+ <li><a href="/">Try the new Zeppelin</a></li>
Review Comment:
A different wording should be used at this point.
##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -226,8 +226,8 @@ protected void configure() {
});
// Multiple Web UI
- final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf,
zConf.getString(ConfVars.ZEPPELIN_WAR), zConf.getServerContextPath());
- final WebAppContext nextWebApp = setupWebAppContext(contexts, zConf,
zConf.getString(ConfVars.ZEPPELIN_ANGULAR_WAR), WEB_APP_CONTEXT_NEXT);
+ final WebAppContext defaultWebApp = setupWebAppContext(contexts, zConf,
zConf.getString(ConfVars.ZEPPELIN_WAR), WEB_APP_CONTEXT_CLASSIC);
Review Comment:
I think it makes sense to rename the Java variables as well.
##########
zeppelin-web-angular/src/app/share/header/header.component.html:
##########
@@ -67,7 +67,7 @@
<li nz-menu-item (click)="logout()">Logout</li>
</ng-container>
<li nz-menu-divider></li>
- <li nz-menu-item><a href="/">Old Version</a></li>
+ <li nz-menu-item><a href="/classic">Old Version</a></li>
Review Comment:
Perhaps “Classic Version” should be used here instead of “Old Version”.
```suggestion
<li nz-menu-item><a href="/classic">Classic Version</a></li>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
