tbonelee opened a new pull request, #4809:
URL: https://github.com/apache/zeppelin/pull/4809

   ### What is this PR for?
   
   The current issue is that the new UI fails to render dynamically created 
components at runtime, which causes the `%sh.terminal` interpreter to 
malfunction.
   
   This problem occurs because Angular's AOT compiler removes decorators during 
the build process.([related 
issue](https://github.com/angular/angular-cli/issues/9306))
   
   As far as I know, Angular does not support JIT compilation alongside the AOT 
compiler.
   
   However, we need to render runtime dynamic components for compatibility 
reasons.
   
   By Importing and re-exporting Angular core decorators, we can prevent the 
AOT compiler from removing them.
   (https://github.com/angular/angular-cli/issues/9306#issuecomment-435404174)
   I believe there are two possible solutions: either implementing this fix or 
turning off AOT compilation.
   However, giving up the performance benefits of AOT compilation is not ideal, 
So I chose this approach.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/6076
   
   ### How should this be tested?
   - Run `%sh.terminal` interpreter and see if it renders well. 
     Note: Since Angular dev servers do not use AOT compilation, testing in 
development mode will not reproduce the issue.
   
   ### Screenshots (if appropriate)
   
   #### Before
   
   
![image](https://github.com/user-attachments/assets/09c20c58-e86b-4432-b2ed-ee971c74af8a)
   
   #### After
   
   <img width="1462" alt="image" 
src="https://github.com/user-attachments/assets/b7f6273b-4323-4f59-a23f-02e7696196b7";>
   - The connection status message appears broken due to incompatibility 
between Angular and AngularJS syntax, but this does not affect functionality. 
(This can be addressed in a separate issue.)
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to