Reamer commented on PR #4507: URL: https://github.com/apache/zeppelin/pull/4507#issuecomment-2331856698
@jongyoul `org.apache.jena:jena-arq` requires jdk 11. Currently Zeppelin is build with jdk8, so we get build errors https://github.com/apache/zeppelin/actions/runs/10712570211/job/29703189803 This change also requires some adjustments in our codebase. ```patch diff --git a/sparql/src/main/java/org/apache/zeppelin/sparql/JenaInterpreter.java b/sparql/src/main/java/org/apache/zeppelin/sparql/JenaInterpreter.java index 9faf86908..3a3be3be7 100644 --- a/sparql/src/main/java/org/apache/zeppelin/sparql/JenaInterpreter.java +++ b/sparql/src/main/java/org/apache/zeppelin/sparql/JenaInterpreter.java @@ -57,7 +57,7 @@ public class JenaInterpreter implements SparqlEngine { @Override public InterpreterResult query(String query) { - LOGGER.info("SPARQL: Run Query '" + query + "' against " + serviceEndpoint); + LOGGER.info("SPARQL: Run Query '{}' against {}", query, serviceEndpoint); try { queryExecution = QueryExecutionFactory.sparqlService(serviceEndpoint, query); @@ -92,7 +92,7 @@ public class JenaInterpreter implements SparqlEngine { "Error: " + e.getMessage()); } catch (QueryExceptionHTTP e) { LOGGER.error(e.toString()); - int responseCode = e.getResponseCode(); + int responseCode = e.getStatusCode(); if (responseCode == HttpStatus.SC_UNAUTHORIZED) { return new InterpreterResult( diff --git a/sparql/src/test/java/org/apache/zeppelin/sparql/SparqlJenaEngineTest.java b/sparql/src/test/java/org/apache/zeppelin/sparql/SparqlJenaEngineTest.java index 84195bbcf..548880437 100644 --- a/sparql/src/test/java/org/apache/zeppelin/sparql/SparqlJenaEngineTest.java +++ b/sparql/src/test/java/org/apache/zeppelin/sparql/SparqlJenaEngineTest.java @@ -17,9 +17,11 @@ package org.apache.zeppelin.sparql; +import org.apache.jena.atlas.web.WebLib; import org.apache.jena.fuseki.Fuseki; import org.apache.jena.fuseki.main.FusekiServer; import org.apache.jena.fuseki.server.DataAccessPointRegistry; +import org.apache.jena.fuseki.system.FusekiNetLib; import org.apache.jena.query.Dataset; import org.apache.jena.query.DatasetFactory; import org.apache.jena.rdf.model.Model; @@ -52,7 +54,8 @@ class SparqlJenaEngineTest { @BeforeAll public static void setUp() { - port = Fuseki.choosePort(); + + port = WebLib.choosePort(); Model model = ModelFactory.createDefaultModel(); model.read(DATA_FILE); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
