Reamer commented on code in PR #4813:
URL: https://github.com/apache/zeppelin/pull/4813#discussion_r1761001476
##########
spark/interpreter/src/main/scala/org/apache/zeppelin/display/angular/AbstractAngularElem.scala:
##########
@@ -134,7 +134,7 @@ abstract class AbstractAngularElem(val interpreterContext:
InterpreterContext,
Text(s"${functionName}=${functionName} + 1"),
Null)
- val angularObject = addAngularObject(functionName, 0)
+ val angularObject = addAngularObject(functionName, Int.box(0))
Review Comment:
This is the only place where I am not sure that this is completely correct.
##########
spark/interpreter/src/main/scala/org/apache/zeppelin/display/angular/AbstractAngularElem.scala:
##########
@@ -70,7 +70,7 @@ abstract class AbstractAngularElem(val interpreterContext:
InterpreterContext,
* @return
*/
@ZeppelinApi
- def model(name: String, value: Any): AbstractAngularElem = {
+ def model(name: String, value: AnyRef): AbstractAngularElem = {
Review Comment:
AnyRef is the same as object.
https://docs.scala-lang.org/tour/unified-types.html#scala-type-hierarchy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
