Kimahriman commented on code in PR #4825:
URL: https://github.com/apache/zeppelin/pull/4825#discussion_r1779811023
##########
spark/spark-shims/src/main/java/org/apache/zeppelin/spark/SparkShims.java:
##########
@@ -58,7 +58,7 @@ public SparkShims(Properties properties) {
private static SparkShims loadShims(int sparkMajorVersion, Properties
properties, Object entryPoint)
throws Exception {
Class<?> sparkShimsClass;
- if (sparkMajorVersion == 3) {
+ if (sparkMajorVersion == 3 || sparkMajorVersion == 4) {
LOGGER.info("Initializing shims for Spark 3.x");
sparkShimsClass = Class.forName("org.apache.zeppelin.spark.Spark3Shims");
Review Comment:
I've been trying to remove the shims and consolidate things but I keep
running into class loading errors and I'm not really sure what to do about it.
I moved most from the shim into a `SparkInterpreterUtils` class in a
`spark-common` module, but just keep running into
```
IllegalAccess failed to access class
org.apache.zeppelin.spark.SparkInterpreterUtils from class
org.apache.zeppelin.spark.SparkScala213Interpreter
(org.apache.zeppelin.spark.SparkInterpreterUtils is in unnamed module of loader
'app'; org.apache.zeppelin.spark.SparkScala213Interpreter is in unnamed module
of loader java.net.URLClassLoader @2c768ada)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
