pan3793 commented on code in PR #4884:
URL: https://github.com/apache/zeppelin/pull/4884#discussion_r1818325013
##########
elasticsearch/src/test/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreterTest.java:
##########
@@ -94,33 +94,31 @@ public static void populate() throws IOException {
.setRefresh(true)
.setSource(jsonBuilder()
.startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host:
apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
- .get();
+ .field("date", new Date())
+ .startObject("request")
+ .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
+ .field("url", "/zeppelin/" + UUID.randomUUID().toString())
+ .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
+ .endObject()
+ .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
+ .field("content_length", RandomUtils.nextInt(0, 2000))
+ ).get();
}
for (int i = 1; i < 3; i++) {
elsClient.prepareIndex("logs", "http", "very/strange/id#" + i)
.setRefresh(true)
.setSource(jsonBuilder()
- .startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0,
METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host:
apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
Review Comment:
can we keep the indent? the original one has better readability
##########
elasticsearch/src/test/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreterTest.java:
##########
@@ -94,33 +94,31 @@ public static void populate() throws IOException {
.setRefresh(true)
.setSource(jsonBuilder()
.startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host:
apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
- .get();
+ .field("date", new Date())
+ .startObject("request")
+ .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
+ .field("url", "/zeppelin/" + UUID.randomUUID().toString())
+ .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
+ .endObject()
+ .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
+ .field("content_length", RandomUtils.nextInt(0, 2000))
+ ).get();
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
