Reamer commented on code in PR #4908:
URL: https://github.com/apache/zeppelin/pull/4908#discussion_r2012297965
##########
hbase/src/main/java/org/apache/zeppelin/hbase/HbaseInterpreter.java:
##########
@@ -143,30 +145,25 @@ public Scheduler getScheduler() {
HbaseInterpreter.class.getName() + this.hashCode());
}
- @Override
- public List<InterpreterCompletion> completion(String buf, int cursor,
- InterpreterContext interpreterContext) {
- return null;
+ private String getScriptFileName(String paragraphId) {
+ return String.format("%s%s.txt", getScriptDir(), paragraphId);
}
- private static String getSystemDefault(
- String envName,
- String propertyName,
- String defaultValue) {
-
- if (envName != null && !envName.isEmpty()) {
- String envValue = System.getenv().get(envName);
- if (envValue != null) {
- return envValue;
- }
+ private String getScriptDir() {
+ String tmpProperty = System.getProperty("java.io.tmpdir");
Review Comment:
I'm not a fan of fixed strings. We should use a method directly from Java to
create a temp directory.
Files.createTempFile
or Files.createTempDirectory should be useful.
##########
docs/interpreter/hbase.md:
##########
@@ -28,19 +28,7 @@ limitations under the License.
To get start with HBase, please see [HBase
Quickstart](https://hbase.apache.org/book.html#quickstart).
## HBase release supported
-By default, Zeppelin is built against HBase 1.0.x releases. To work with HBase
1.1.x releases, use the following build command:
-
-```bash
-# HBase 1.1.4
-./mvnw clean package -DskipTests -Phadoop-2.6 -Dhadoop.version=2.6.0 -P
build-distr -Dhbase.hbase.version=1.1.4 -Dhbase.hadoop.version=2.6.0
-```
-
-To work with HBase 1.2.0+, use the following build command:
-
-```bash
-# HBase 1.2.0
-./mvnw clean package -DskipTests -Phadoop-2.6 -Dhadoop.version=2.6.0 -P
build-distr -Dhbase.hbase.version=1.2.0 -Dhbase.hadoop.version=2.6.0
-```
+Zeppelin is built against HBase 2.x releases.
Review Comment:
If you rely on a shell script, this statement is no longer correct, is it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
