Henry-Hong commented on code in PR #4952:
URL: https://github.com/apache/zeppelin/pull/4952#discussion_r2203214239
##########
zeppelin-web-angular/src/app/services/completion.service.ts:
##########
@@ -76,12 +78,19 @@ export class CompletionService extends
MessageListenersManager {
take(1),
map(d => {
return {
- suggestions: d.completions.map(i => ({
- kind: monaco.languages.CompletionItemKind.Keyword,
- label: i.name,
- insertText: i.name,
- range: undefined
- }))
+ suggestions: d.completions.map(
+ (i): languages.CompletionItem => ({
+ kind: languages.CompletionItemKind.Keyword,
+ label: i.name,
+ insertText: i.name,
+ range: {
+ startLineNumber: position.lineNumber,
+ endLineNumber: position.lineNumber,
+ startColumn: word.startColumn,
+ endColumn: word.endColumn
+ }
+ })
+ )
Review Comment:
Such a nice work!!
Since these are UI changes, it would be really helpful to see an as-is/to-be
demo on PR Readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
